Fix webscoket TLS bug #11243
Merged
Fix webscoket TLS bug #11243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jul 7, 2021
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
area/websocket
type/bug
Technoboy-
force-pushed
the
fix-proxy-websocket-ssl
branch
from
47061e9
to
ef0cb40
Compare
|
/pulsarbot run-failure-checks |
2. Add ProxyServiceTlsStarterTest. 3. Refactor ProxyServiceStarter to be more easy to test.
Technoboy-
force-pushed
the
fix-proxy-websocket-ssl
branch
from
ef0cb40
to
849651c
Compare
congbobo184
approved these changes
Jul 7, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
2. Add ProxyServiceTlsStarterTest. 3. Refactor ProxyServiceStarter to be more easy to test. (cherry picked from commit 887d74f)
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
2. Add ProxyServiceTlsStarterTest. 3. Refactor ProxyServiceStarter to be more easy to test. (cherry picked from commit 887d74f)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
2. Add ProxyServiceTlsStarterTest. 3. Refactor ProxyServiceStarter to be more easy to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix webscoket tls bug and add test case.
Modifications
Add mapping : serviceConfiguration.setBrokerClientTlsEnabled(config.isTlsEnabledWithBroker());.
Add ProxyServiceTlsStarterTest.java
Ajuest ProxyServiceStarter to be more easy to test.
Verifying this change